Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swig4.0 binary. #120

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Add swig4.0 binary. #120

merged 1 commit into from
Feb 18, 2024

Conversation

dpad
Copy link
Contributor

@dpad dpad commented Feb 17, 2024

Some tools (e.g. FindSWIG in CMake) search for a binary named swig4.0 instead of swig (even when the version is actually "4.2.0", for example). This change simply adds a swig4.0 binary alongside the swig binary already installed by this package.

See: https://gitlab.kitware.com/cmake/cmake/-/issues/25566

… searching for that name (e.g. FindSWIG in CMake).
Copy link
Owner

@nightlark nightlark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting quirk, cmake. Changes lgtm.

@nightlark nightlark merged commit 52d8955 into nightlark:main Feb 18, 2024
15 checks passed
@dpad dpad deleted the add-swig4.0-bin branch February 18, 2024 15:25
@dpad
Copy link
Contributor Author

dpad commented Feb 19, 2024

@nightlark Thanks very much for your quick merge and all your work on this package! Any chance I could trouble you for a .post0 release?

@nightlark
Copy link
Owner

A 4.2.0.post0 package should be available now.

@nightlark nightlark mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants